[Snyk] Upgrade react-native-screens from 4.19.0 to 4.20.0#39
Conversation
Snyk has created this PR to upgrade react-native-screens from 4.19.0 to 4.20.0. See this package in npm: react-native-screens See this project in Snyk: https://app.snyk.io/org/chirag127/project/4c20a98f-d4af-4651-bd1c-01c83de1eee7?utm_source=github&utm_medium=referral&page=upgrade-pr
Summary of ChangesHello @chirag127, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the upgrade of the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request, generated by Snyk, upgrades react-native-screens from version 4.19.0 to 4.20.0. It also adjusts the version specifiers for several other dependencies in package-lock.json from ^ (caret) to ~ (tilde), making them more restrictive. My review focuses on ensuring consistency in these dependency specifiers. I've found one minor inconsistency that should be addressed.
| "react-native-reanimated": "~3.19.3", | ||
| "react-native-safe-area-context": "4.12.0", | ||
| "react-native-screens": "^4.19.0", | ||
| "react-native-screens": "^4.20.0", |
There was a problem hiding this comment.
For consistency with package.json and the other dependency updates in this PR, the version specifier for react-native-screens should be ~4.20.0 instead of ^4.20.0.
This change would align with the ~ prefix used in package.json and the modifications made to other packages like expo-constants, ensuring more restrictive and predictable versioning.
| "react-native-screens": "^4.20.0", | |
| "react-native-screens": "~4.20.0", |
Snyk has created this PR to upgrade react-native-screens from 4.19.0 to 4.20.0. See this package in npm: react-native-screens See this project in Snyk: https://app.snyk.io/org/whyiswhen/project/aed39381-6e7d-41b9-b7ea-15e35a2ff0f9?utm_source=github&utm_medium=referral&page=upgrade-pr
|
Important Review skippedIgnore keyword(s) in the title. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
2 participants
Snyk has created this PR to upgrade react-native-screens from 4.19.0 to 4.20.0.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 36 versions ahead of your current version.
The recommended version was released 22 days ago.
Release notes
Package name: react-native-screens
What's Changed
Minor release bringing improvements to formSheet on Android in form of support for "dynamic content size" when
fitToContentsis selected. Beside that important a11y update for bottom tabs and other fixes.🟢 Improvements
🐛 Bug fixes
ScreenStackHosttoStackHostby @ kkafar in #3486maxLifecycleStatetoactivityModeby @ kkafar in #3505Tabsobject + dropBottom*prefix by @ kkafar in #3535🔢 Misc
sheetShouldOverflowTopInsetby @ t0maboro in #3503StackContainerimplementation by @ kkafar in #3518New Contributors
Full Changelog: 4.19.0...4.20.0
What's Changed
Minor release. It comes with many improvements & bug fixes. Notably:
bottomAccessorysupport for native tabs on iOS,See the full change set below 👇🏻
Improvements
snapshotAfterUpdatesproperty toRNSScreenViewby @ bartlomiejbloniarz in #3296Bug fixes
stackPresentationandheaderConfig.hiddeninScreenStackItemby @ kligarski in #3374src/types.tsxby @ kligarski in #3394noneenvironment in Bottom Accessory by @ kligarski in #3416